-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump graphql-upload to 15.0.2 #18811
chore(deps): bump graphql-upload to 15.0.2 #18811
Conversation
877d17a
to
678641f
Compare
678641f
to
d77b6ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and everything seems to work fine.
Looking at the graphql-upload changelog, 15.0.2 seems like a good compromise.
I've re-run the tests, waiting for them to pass before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there are still some linting issues: https://github.com/strapi/strapi/actions/runs/7142538962/job/19455465655?pr=18811#step:7:573
Would you mind fixing them before we can merge?
Thanks @Convly - update pushed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update & the PR, I'll merge it and give it another round of QA next week
What does it do?
Bumps
graphql-upload
from^13.0.0
to15.0.2
Why is it needed?
Remediates CVE-2022-24434
How to test it?
Existing API integration tests:
graphql-upload-automatic-folder.test.api.js
graphql-upload.test.api.js
Related issue(s)/PR(s)
Fix #18783