Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump graphql-upload to 15.0.2 #18811

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

josephemswiler
Copy link
Contributor

@josephemswiler josephemswiler commented Nov 16, 2023

What does it do?

Bumps graphql-upload from ^13.0.0 to 15.0.2

Why is it needed?

Remediates CVE-2022-24434

How to test it?

Existing API integration tests:

  • graphql-upload-automatic-folder.test.api.js
  • graphql-upload.test.api.js

Related issue(s)/PR(s)

Fix #18783

@markkaylor markkaylor added source: plugin:graphql Source is plugin/graphql package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Nov 21, 2023
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and everything seems to work fine.
Looking at the graphql-upload changelog, 15.0.2 seems like a good compromise.

I've re-run the tests, waiting for them to pass before merging

@Convly Convly added this to the 4.15.6 milestone Dec 8, 2023
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there are still some linting issues: https://github.com/strapi/strapi/actions/runs/7142538962/job/19455465655?pr=18811#step:7:573
Would you mind fixing them before we can merge?

@josephemswiler
Copy link
Contributor Author

Thanks @Convly - update pushed!

Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update & the PR, I'll merge it and give it another round of QA next week

@Convly Convly merged commit 0ad5d09 into strapi:main Dec 15, 2023
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: plugin:graphql Source is plugin/graphql package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: upgrade graphql-upload in @strapi/plugin-graphql to >=15.0.0 to fix CVE-2022-24434
3 participants