Fix/aws credentials #18812
Merged
Fix/aws credentials #18812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiancp100
added
pr: fix
|
Size Change: +643 B (0%) Total Size: 645 kB
ℹ️ View Unchanged
|
innerdvations
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It makes the accessKeyId and secretKeyId optional in the AWS S3 provider because these credentials can be omitted when strapi is deployed on and EC2 instance or on another AWS service that supports IAM Profiles instead of accessKeyId and secretAccessKey.
Why is it needed?
To support other types of authentication in the AWS provider
How to test it?
Check that if you don't pass the credentials and have an EC2 instance with another type of authentication configured, the provider works as expected
Related issue(s)/PR(s)
Closes #18718
Merged on main: #18733
Let us know if this is related to any issue/pull request
What does it do?
Describe the technical changes you did.
Why is it needed?
Describe the issue you are solving.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
#18800