-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with case sensitive email addresses sent by some SSO providers #18883
Conversation
Was this working in 4.14 and broken in 4.15? If not, let's target main to avoid potentially introducing something new. |
I figured this could be an easy fix to have in the next release but if we want to be extra cautious I can target another version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just to be sure, I also confirmed that the unique check on account creation is case insensitive (that is, it shouldn't be possible to have multiple accounts with different casing) so this should be safe.
545522a
to
fc55046
Compare
Yeah, it seems very simple and totally safe to me, but those are always the ones that always seem to end up breaking something unexpected 😆 |
building experimental: https://github.com/strapi/strapi/actions/runs/7090551315 |
What does it do?
Use a case-insensitive lookup for admin users in the findOneByEmail method of the user service.
Why is it needed?
See #16982
How to test it?
yarn strapi console
and then making a manual query to the admin user service.Related issue(s)/PR(s)
fix #16982