Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Tool] Version Targeting Strategy V2 #18906

Merged
merged 5 commits into from Nov 27, 2023

Conversation

Convly
Copy link
Member

@Convly Convly commented Nov 24, 2023

What does it do?

  • Default the CLI's target to next
  • Add the exact mode, which allows targeting a single upgrade when specifying a target in the form "x.x.x"
  • Accept versions lower than the current one in exact mode
  • Add the current and next target options
  • Modify the behavior of major, minor and patch upgrades
    • major now targets the current or next major (current +1), + its latest minor andpatch
    • minor now targets the current major, the current or next minor (current +1), + its latest patch
    • patch now targets the current major, the current minor and the current patch + 1

Why is it needed?

  • Making the targeting strategy more consistent and user friendly
  • Allow running atomic upgrades
  • Allow running previous upgrades

Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Like we talked about earlier, the actual flow will be different, but it'll be great to have all this flexibility to design the tool with!

@Convly Convly merged commit 2628ba1 into features/upgrade-tool Nov 27, 2023
1 of 3 checks passed
@Convly Convly deleted the upgrade-tool/versionning-v2 branch November 27, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants