Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-releases): Edit Release #18956

Merged
merged 13 commits into from
Dec 4, 2023

Conversation

simotae14
Copy link
Contributor

What does it do?

Enable the Edit button in the Details page to change the release name

Why is it needed?

We need a way to edit the release name

How to test it?

You can go to the Release page and create new Release

  • then in the ReleaseDetails page with some data mocked, you can click on the three dots button and see the Edit button
  • when you click on the edit button the Dialog with the actual release title (a mocked value) is shown and you can change the value and save it

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Size Change: +277 B (0%)

Total Size: 665 kB

Filename Size Change
examples/getstarted/build/main.********.js 657 kB +274 B (0%)
ℹ️ View Unchanged
Filename Size Change
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
examples/getstarted/build/index.html 609 B +1 B (0%)
examples/getstarted/build/runtime~main.********.js 4.28 kB +2 B (0%)

compressed-size-action

Copy link
Contributor

@Feranchz Feranchz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of small comments, it's great to see how all pieces are coming together 🎉

Copy link
Contributor

@Feranchz Feranchz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did QA locally and working without problems 🎉

Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

@simotae14 simotae14 merged commit b4936e0 into feature/content-releases Dec 4, 2023
22 checks passed
@simotae14 simotae14 deleted the content-release/edit-release branch December 4, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants