Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deep query populate issue on dynamic zone #18966

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

Bassel17
Copy link
Member

@Bassel17 Bassel17 commented Dec 1, 2023

What does it do?

Fixes deep populate issue with a wildcard notation

Why is it needed?

It's a regression introduced by a previous PR

How to test it?

  • Create a dynamic zone with at least two components, add relational field in at least one of the components
  • attempt to fetch with following query http://localhost:1337/api/countries?populate[dynamiczone][populate]=*
  • relational fields should be populated

Related issue(s)/PR(s)

fixes #17654

@Bassel17 Bassel17 added source: core:utils Source is core/utils or utils packages pr: fix This PR is fixing a bug labels Dec 1, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Size Change: 0 B

Total Size: 645 kB

ℹ️ View Unchanged
Filename Size
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB
examples/getstarted/build/index.html 611 B
examples/getstarted/build/main.********.js 638 kB
examples/getstarted/build/runtime~main.********.js 4.26 kB

compressed-size-action

Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Convly
Copy link
Member

Convly commented Dec 5, 2023

Tested it manually and everything seems to work 🙂

@Bassel17 Bassel17 added this to the 4.15.6 milestone Dec 5, 2023
@Bassel17 Bassel17 merged commit 8e2421b into main Dec 5, 2023
146 checks passed
@Bassel17 Bassel17 deleted the fix/deep-populate-dynamiczone branch December 5, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:utils Source is core/utils or utils packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants