feat(content-releases): Delete a Release #19000
Conversation
Feranchz
added
pr: feature
There was a problem hiding this comment.
It looks good to me and is deleting the release and removing the relation between a release and a release action. Currently though the release actions associated are not also deleted but I think want them to be. Idk with the entity service if we can cascade the delete or if we have to do it manually 🤔
But don't get trigger happy and also delete the entry 🙃
…nto content-releases/delete-controller
| const deletedRelease = (await strapi.entityService.delete(RELEASE_MODEL_UID, releaseId, { | ||
| populate: { actions: { fields: ['id'] } }, | ||
| })) as unknown as Release; | ||
|
|
||
| // We delete each action related to the release | ||
| if (deletedRelease.actions) { | ||
| await strapi.db.query(RELEASE_ACTION_MODEL_UID).deleteMany({ | ||
| where: { | ||
| id: { | ||
| $in: deletedRelease.actions.map(({ id }) => id), | ||
| }, | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
So no matter what we delete the release right? If something goes wrong deleting the actions then what will happen? An error throws in the deleteMany, the release is already deleted, and we return an error? Seems a bit misleading in that case.
I'm wondering if the order of operations matters here. delete the actions, when that's a success delete the release? 🤔
There was a problem hiding this comment.
I think the order you proposed is right, we should delete the actions firsts.
I also added a transaction for this, because in my opinion it's the perfect use case: We want to delete the release and all its actions only if we can delete all without problems 🤔
| }, | ||
| }, | ||
| }); | ||
| await strapi.entityService.delete(RELEASE_MODEL_UID, releaseId); |
There was a problem hiding this comment.
I notice here you perform the delete of the release inside the transaction, whereas for update you update the releas outside the transaction. What's the difference?
There was a problem hiding this comment.
I guess you mean when publishing a release...
Actually it's a good point, in the publishing case makes more sense put that update inside the transaction 🤔, so we make sure we don't publish entries if the update fails (it's a unlikely case but I guess is possible)
Are you okay if I make that change in this same PR?
There was a problem hiding this comment.
Hey yeah that's fine by me to make the same update here in this PR if you want otherwise this one looks good and we can merge.
What does it do?
Add a new
/content-releases/:id/delete endpoint to delete a release.How to test it?
Make sure you have the content-releases feature enabled with a EE project.
/content-releases/:releaseId