Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(pack-up): fix config file name in readme #19037

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

remidej
Copy link
Contributor

@remidej remidej commented Dec 12, 2023

What does it do?

Makes some changes to the pack-up readme about the name of the config file

Why is it needed?

I think it was wrong. packup.config.ts is the file name used throughout the monorepo. And I tried on another repo using pack-up (the renderer), the config wasn't picked up unless I called it packup.config.ts

@remidej remidej added pr: doc This PR contributes to the documentation in this repository (READMEs or Comments) source: utils:pack-up Source is utils/pack-up package labels Dec 12, 2023
@remidej remidej self-assigned this Dec 12, 2023
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄

@remidej remidej added this to the 4.15.6 milestone Dec 12, 2023
@remidej remidej merged commit a3bd045 into main Dec 12, 2023
29 checks passed
@remidej remidej deleted the doc/pack-up-config branch December 12, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: doc This PR contributes to the documentation in this repository (READMEs or Comments) source: utils:pack-up Source is utils/pack-up package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants