Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content manager] Refactor useContentManagerInitData to remove ModelsContext #19042

Merged
merged 6 commits into from Dec 19, 2023

Conversation

jhoward1994
Copy link
Contributor

What does it do?

Refactor useContentManagerInitData to use react query and remove ModelsContext

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@jhoward1994 jhoward1994 self-assigned this Dec 13, 2023
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, some feedback

@jhoward1994 jhoward1994 added the flag: 💥 Breaking change This PR contains breaking changes and should not be merged label Dec 15, 2023
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Jamie ✨ have you written this in the breaking changes table for piwi?

@jhoward1994 jhoward1994 added this to the 5.0.0 milestone Dec 19, 2023
@jhoward1994 jhoward1994 merged commit b5711d6 into v5/main Dec 19, 2023
22 checks passed
@jhoward1994 jhoward1994 deleted the v5/remove-models-context-2 branch December 19, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: 💥 Breaking change This PR contains breaking changes and should not be merged
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants