-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(content-manager): search relations with contains not startsWith #19043
fix(content-manager): search relations with contains not startsWith #19043
Conversation
Your changes have broken front end tests, please can you fix them? |
@joshuaellis I've sorted out the front-end test issues in commit 7bc8ccc. Take a look, and feel free to let me know if there's anything else needed 👍 |
Hi @joshuaellis 👋 |
I need to find time again to re-test manually – this will be done when it's done. To set an expectation, this won't be released most likely till next year as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, QA'd and just updated the title so it's even clearer.
Thanks! Appreciate the feedback and the title update. 👍 |
actual PR – #19043 Co-Authored-By: Arshia <arshia.shahidi@gmail.com>
What does it do?
This PR addresses and fixes two specific issues: #17391 and #18257. The main focus is on resolving the problem related to searching within a relational input.
The changes include using
"none"
for autocomplete and updating the filter logic to_filter: '$containsi'
Additionally, it enhances the functionality by passing the
textValue
to theonSearch
function in thehandleMenuOpen
handler, ensuring proper search results when the menu is opened with typing.Why is it needed?
The issues #17391 and #18257 highlighted a problem with searching in a relational input. This PR aims to solve this issue by making necessary changes and further improves the user experience by passing the text value to the
onSearch
function.How to test it?
To verify the behavior of this fix, follow these steps:
Related issue(s)/PR(s)
This PR is related to the following issues:
Note to Reviewer @joshuaellis :