-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content-releases): Add action column to details view #19046
feat(content-releases): Add action column to details view #19046
Conversation
49283e9
to
90e80c5
Compare
Size Change: -138 B (0%) Total Size: 665 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have one small comment for the code. But I'm not sure it's working as expected, at least not on my side:
Screen.Recording.2023-12-13.at.17.58.21.mov
packages/core/content-releases/admin/src/pages/ReleaseDetailsPage.tsx
Outdated
Show resolved
Hide resolved
Thanks for that video @markkaylor, I had an error in the Publish buttons component, now should work everything 🎉 I also take time to solve a small but important bug in RTK: When creating an action (This means add a new action to a release), we need to invalidate not only the release actions, but also the release |
packages/core/content-releases/admin/src/pages/ReleaseDetailsPage.tsx
Outdated
Show resolved
Hide resolved
packages/core/content-releases/admin/src/pages/ReleaseDetailsPage.tsx
Outdated
Show resolved
Hide resolved
7919efe
to
95fd275
Compare
95fd275
to
858bcae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the rtk fix too. Tested locally ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works as expected, great work
What does it do?
This PR add the action column to the details view, in this column you can change the type of the action (publish or unpublish)
How to test it?
You should have an EE license and the feature enabled by setting contentReleases as enabled on the feature file.