Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-releases): Add action column to details view #19046

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

Feranchz
Copy link
Contributor

⚠️ Wait for Simone's PR to be merged first, and then we can merge his last updated work here and change this PR to point into feature branch

What does it do?

This PR add the action column to the details view, in this column you can change the type of the action (publish or unpublish)

How to test it?

You should have an EE license and the feature enabled by setting contentReleases as enabled on the feature file.

// myproject/config/features.js
module.exports = ({ env }) => ({
  future: {
    contentReleases: true
  },
});
  1. Then go to a release with actions (Create one and assign actions to it)
  2. You should see a new column with the action
  3. You can change the action and the change should be reflect on the UI

@Feranchz Feranchz self-assigned this Dec 13, 2023
Base automatically changed from content-release/release-details-table-release-actions to feature/content-releases December 13, 2023 14:59
@Feranchz Feranchz force-pushed the content-release/action-column branch from 49283e9 to 90e80c5 Compare December 13, 2023 15:12
Copy link
Contributor

github-actions bot commented Dec 13, 2023

Size Change: -138 B (0%)

Total Size: 665 kB

Filename Size Change
examples/getstarted/build/main.********.js 658 kB -133 B (0%)
ℹ️ View Unchanged
Filename Size Change
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
examples/getstarted/build/index.html 609 B -2 B (0%)
examples/getstarted/build/runtime~main.********.js 4.28 kB -3 B (0%)

compressed-size-action

Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one small comment for the code. But I'm not sure it's working as expected, at least not on my side:

Screen.Recording.2023-12-13.at.17.58.21.mov

@Feranchz
Copy link
Contributor Author

Feranchz commented Dec 13, 2023

Thanks for that video @markkaylor, I had an error in the Publish buttons component, now should work everything 🎉

I also take time to solve a small but important bug in RTK: When creating an action (This means add a new action to a release), we need to invalidate not only the release actions, but also the release

@Feranchz Feranchz force-pushed the content-release/action-column branch from 95fd275 to 858bcae Compare December 14, 2023 09:11
Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the rtk fix too. Tested locally ✅

Copy link
Contributor

@simotae14 simotae14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works as expected, great work

@Feranchz Feranchz merged commit 849c812 into feature/content-releases Dec 14, 2023
22 checks passed
@Feranchz Feranchz deleted the content-release/action-column branch December 14, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants