Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-releases): add functionality to publish release button #19055

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

Feranchz
Copy link
Contributor

What does it do?

Link publish button in release details view with its endpoint.

How to test it?

You should have an EE license and the feature enabled by setting contentReleases as enabled on the feature file.

// myproject/config/features.js
module.exports = ({ env }) => ({
  future: {
    contentReleases: true
  },
});
  1. Create a new release and add entries to it
  2. Publish this release clicking on the "Release" button on the top right
  3. You should see a success message and now the release is on "only-view" mode
  4. All the entries related should be published/unpublished

Copy link
Contributor

github-actions bot commented Dec 14, 2023

Size Change: +109 B (0%)

Total Size: 666 kB

Filename Size Change
examples/getstarted/build/main.********.js 659 kB +106 B (0%)
ℹ️ View Unchanged
Filename Size Change
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
examples/getstarted/build/index.html 611 B +2 B (0%)
examples/getstarted/build/runtime~main.********.js 4.28 kB +1 B (0%)

compressed-size-action

Copy link
Contributor

@simotae14 simotae14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the feature and it works, just one question, I saw the Release button enabled even if you don't have actions to release, is it not better to disable the button until we have actions?

@Feranchz Feranchz force-pushed the content-releases/publish-button branch from 4362a67 to 3d86b1a Compare December 14, 2023 13:42
Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Feranchz Feranchz merged commit 75149a8 into feature/content-releases Dec 14, 2023
22 checks passed
@Feranchz Feranchz deleted the content-releases/publish-button branch December 14, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants