Remove deprecated isSupportedImage #19204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerdvations
added
source: core:upload
Marc-Roig
approved these changes
Jan 11, 2024
|
do you know if we have a list of internal breaking changes? |
|
I'm going to have it documented as breaking in the release because even though it's not in our documentation, it's mentioned in many forum and blog posts. |
innerdvations
added
the
flag: 💥 Breaking change
Convly
reviewed
Jan 12, 2024
echoes-hq
bot
added
the
echoes/type: feature/deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
removes isSupportedImage from upload image-manipulation library
Why is it needed?
it was deprecated to be removed in v5
How to test it?
it shouldn't exist anymore, and graphql uploads of optimizable images should still work
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request