Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove default index page from public middleware #19270

Merged
merged 1 commit into from Jan 19, 2024

Conversation

alexandrebodin
Copy link
Member

What does it do?

Remove the default index page and redirect to the admin directly

Why is it needed?

To make it easier to find the admin and remove old code.

How to test it?

go to http://localhost:1337/ and get redirect to /admin. Check uploaded files are still accessible and visible in the media lib

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@alexandrebodin alexandrebodin added source: core:strapi Source is core/strapi package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Jan 18, 2024
@alexandrebodin alexandrebodin self-assigned this Jan 18, 2024
Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested locally:

  • / redirects to /admin
  • Uploads available in the media lib and on /uploads

@alexandrebodin alexandrebodin merged commit 1dd775d into v5/main Jan 19, 2024
79 checks passed
@alexandrebodin alexandrebodin deleted the v5/clean-root-url branch January 19, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants