Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: setup configuration in one place only #19273

Merged
merged 1 commit into from Jan 23, 2024
Merged

chore: setup configuration in one place only #19273

merged 1 commit into from Jan 23, 2024

Conversation

alexandrebodin
Copy link
Member

What does it do?

Setup configuration in one place only and get ride of the old bootstrap file that was confusing

Why is it needed?

To simplify and have a single source of truth for the config

How to test it?

  • Check the different urls we need are valid (u&p, documentation ...)
  • check the serveAdminPanel option is working as expected

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@alexandrebodin alexandrebodin added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:core Source is core/core labels Jan 19, 2024
@alexandrebodin alexandrebodin self-assigned this Jan 19, 2024
@alexandrebodin alexandrebodin added the flag: 💥 Breaking change This PR contains breaking changes and should not be merged label Jan 19, 2024
innerdvations
innerdvations reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES, another very happy change for me

I'm off next week and I didn't have time to QA this one today so I won't click approve yet, but it does have my approval in general

@alexandrebodin alexandrebodin force-pushed the v5/clean-config branch 2 times, most recently from c1d6825 to 0a72e4a Compare January 23, 2024 10:32
Convly
Convly reviewed Jan 23, 2024
View reviewed changes
packages/core/utils/src/config.ts Outdated Show resolved Hide resolved
packages/core/utils/src/config.ts Outdated Show resolved Hide resolved
packages/core/core/src/utils/startup-logger.ts Show resolved Hide resolved
packages/core/utils/src/config.ts Show resolved Hide resolved
Convly
Convly approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit bbc6a32 into v5/main Jan 23, 2024
76 checks passed
@alexandrebodin alexandrebodin deleted the v5/clean-config branch January 23, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerdvations innerdvations innerdvations left review comments

@Convly Convly Convly approved these changes

Assignees

@alexandrebodin alexandrebodin

Labels
flag: 💥 Breaking change This PR contains breaking changes and should not be merged pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:core Source is core/core
Projects
Breaking Change Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexandrebodin @innerdvations @Convly