Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cm): refactor to use redux-toolkit-query #19281

Merged
merged 2 commits into from
Jan 22, 2024
Merged

chore(cm): refactor to use redux-toolkit-query #19281

merged 2 commits into from
Jan 22, 2024

Conversation

joshuaellis
Copy link
Member

What does it do?

  • Converts the CM to use redux-toolkit-query

How to test it?

  • E2E & Unit testing tests a lot of these API calls

Related issue(s)/PR(s)

  • resolves CONTENT-1967

@joshuaellis joshuaellis added source: core:content-manager Source is core/content-manager package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Jan 19, 2024
@joshuaellis joshuaellis added this to the 5.0.0 milestone Jan 19, 2024
@joshuaellis joshuaellis self-assigned this Jan 19, 2024
@joshuaellis joshuaellis force-pushed the v5/cm-redux-toolkit-query branch 3 times, most recently from ac6da97 to 79ba80d Compare January 19, 2024 14:30
Marc-Roig
Marc-Roig approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@Marc-Roig Marc-Roig left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have QAd ListView, EditVie and Settings View , everything seems to be working fine ! 👍
(I have not reviewed the code)

@joshuaellis joshuaellis merged commit f6f0471 into v5/main Jan 22, 2024
76 checks passed
@joshuaellis joshuaellis deleted the v5/cm-redux-toolkit-query branch January 22, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marc-Roig Marc-Roig Marc-Roig approved these changes

@remidej remidej Awaiting requested review from remidej

@jhoward1994 jhoward1994 Awaiting requested review from jhoward1994

Assignees

@joshuaellis joshuaellis

Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:content-manager Source is core/content-manager package
Projects
None yet
Milestone
5.0.0-beta.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshuaellis @Marc-Roig