Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(history): add history-version content type #19316

Merged
merged 4 commits into from Jan 25, 2024

Conversation

remidej
Copy link
Contributor

@remidej remidej commented Jan 24, 2024

What does it do?

Registers a history version content type. It's a content type for now, but it will converted to a model later when Alex finished his database model API proposal.

I had to add a few unusual fields (modelName, globalId) because they were mandatory in the type. I checked against all the other content types at runtime to make sure I matched the right format.

Why is it needed?

To later store content history data

How to test it?

  • build strapi
  • run yarn strapi console
  • paste strapi.contentTypes['plugin::content-manager.history-version']
  • you should see the model

@remidej remidej added source: core:content-manager Source is core/content-manager package pr: feature This PR adds a new feature labels Jan 24, 2024
@remidej remidej self-assigned this Jan 24, 2024
Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Since Marc has some open comments I'll leave the explicit approval to him :)

@remidej remidej merged commit be6cc4a into v5/history Jan 25, 2024
21 of 22 checks passed
@remidej remidej deleted the history/content-type branch January 25, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: feature This PR adds a new feature source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants