[breaking change] Remove the TOrigin Type Param for Attribute.UID #19336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convly
added
flag: 💥 Breaking change
alexandrebodin
approved these changes
Jan 26, 2024
…t/types/remove-uid-origin-param
innerdvations
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The
TOrigintype param forAttribute.UIDwas deprecated in V4 and is not used.This PR aims to remove it completely (from the usage in the code & from the type gen)
Update unit tests
Why is it needed?
Cleanup types
How to test it?
Make sure types that depend on
Attribute.UIDstills work properly and that the type generation no longer adds theTOrigintype param to generated types