New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add history versions endpoint #19386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remidej
added
source: core:content-manager
Source is core/content-manager package
pr: feature
This PR adds a new feature
labels
Jan 31, 2024
markkaylor
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If you don't authenticate it as an admin user via the JWT, you should get an error: ✅
- If you don't give it both contentType and documentId params, you should get an error: ✅
- If you don't have permissions to view the contentType you passed it, you should get an error ✅
- Otherwise you should see an array of relevant history versions in the data key, and a meta object with pagination ✅
- The createdBy author should be populated and sanitized (no password hash) ✅
packages/core/content-manager/shared/contracts/history-versions.ts
Outdated
Show resolved
Hide resolved
packages/core/content-manager/shared/contracts/history-versions.ts
Outdated
Show resolved
Hide resolved
packages/core/content-manager/shared/contracts/history-versions.ts
Outdated
Show resolved
Hide resolved
markkaylor
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: feature
This PR adds a new feature
source: core:content-manager
Source is core/content-manager package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a route that lists the available history versions for a given set of query params.
Things that don't work yet:
Why is it needed?
To list history versions in the frontend.
How to test it?
/content-manager/history-versions
contentType
anddocumentId
params, you should get an errorcontentType
you passed it, you should get an error