feat: list history versions in the history page sidebar #19421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remidej
added
source: core:content-manager
remidej
changed the title
|
Size Change: 0 B Total Size: 2.44 MB ℹ️ View Unchanged
|
joshuaellis
reviewed
Feb 2, 2024
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Outdated
Show resolved
Hide resolved
joshuaellis
previously requested changes
Feb 2, 2024
There was a problem hiding this comment.
I think your approach to passing the locale is too strict, the CM shouldn't really ever be doing query.i18n.XXX instead i would just pass all the plugin params because it's extensible without doing anything extra e.g. if someone extends the endpoints they have to somehow modify the FE to pass their plugins params which they can't do.
in short, I really don't believe we should be passing locale around because the CM shouldn't know about the concept of a locale.
|
@joshuaellis currently my history versions endpoint expects a |
I would do something similar in the CM already where we run a func called const buildValidParams = <TQuery extends Query>(query: TQuery): TransformedQuery<TQuery> => {
if (!query) return query;
// Extract pluginOptions from the query, they shouldn't be part of the URL
const { plugins: _, ...validQueryParams } = {
...query,
...Object.values(query?.plugins ?? {}).reduce<Record<string, string>>(
(acc, current) => Object.assign(acc, current),
{}
),
};
if ('_q' in validQueryParams) {
// Encode the search query here since the paramsSerializer will not
// @ts-expect-error – TODO: fix this type error
validQueryParams._q = encodeURIComponent(validQueryParams._q);
}
return validQueryParams;
};it basically takes the query object that could have |
joshuaellis
reviewed
Feb 2, 2024
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Outdated
Show resolved
Hide resolved
joshuaellis
reviewed
Feb 2, 2024
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Outdated
Show resolved
Hide resolved
joshuaellis
previously approved these changes
Feb 2, 2024
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Outdated
Show resolved
Hide resolved
markkaylor
reviewed
Feb 5, 2024
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/history/components/VersionDetails.tsx
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Outdated
Show resolved
Hide resolved
joshuaellis
reviewed
Feb 5, 2024
packages/core/admin/admin/src/content-manager/history/components/VersionDetails.tsx
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/history/pages/History.tsx
Outdated
Show resolved
Hide resolved
markkaylor
approved these changes
Feb 6, 2024
packages/core/admin/admin/src/content-manager/history/components/VersionsList.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Displays a list of history versions in the history page sidebar
How to test it?
For any entry, open the history page by clicking on the "history" button in the edit view.
(current)