chore: use db model instead of content type #19563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remidej
added
the
source: core:content-manager
remidej
added
the
pr: chore
This comment was marked as spam.
This comment was marked as spam.
markkaylor
reviewed
Feb 21, 2024
Marc-Roig
reviewed
Feb 21, 2024
packages/core/content-manager/server/src/history/models/history-version.ts
Outdated
Show resolved
Hide resolved
Marc-Roig
reviewed
Feb 21, 2024
Comment on lines
+39
to
+44
| createdBy: { | ||
| type: 'relation', | ||
| relation: 'oneToOne', | ||
| target: 'admin::user', | ||
| useJoinTable: false, | ||
| }, |
There was a problem hiding this comment.
is it necessary to use a join table for the created by field?
There was a problem hiding this comment.
Do you think it would be? Here it's false, and for normal content types it's false as well
There was a problem hiding this comment.
didn't select the right section 😓 I think the attribute is correctly set up and will not use a join table, but there is a message about jointable being optional and didn't get why 🤔
There was a problem hiding this comment.
Ah I see. The comment is because TS wanted us to provide a joinTable property (not sure about the name exactly). But it shouldn't be required when useJoinTable is false. The type isn't smart enough for that yet, that's why we expect a TS error here
Marc-Roig
reviewed
Feb 21, 2024
packages/core/content-manager/server/src/history/models/history-version.ts
Outdated
Show resolved
Hide resolved
markkaylor
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Removes the history version content type. Registers a history version model instead.
Why is it needed?
We want to stop using content types for internal stuff, as it doesn't need the CM, CTB, review workflows etc.
How to test it?
Everything should work as it did before