Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(strapi): make watch-admin default on develop #19647

Merged
merged 1 commit into from Mar 1, 2024
Merged

chore(strapi): make watch-admin default on develop #19647

merged 1 commit into from Mar 1, 2024

Conversation

joshuaellis
Copy link
Member

@joshuaellis joshuaellis commented Mar 1, 2024 •
edited

What does it do?

  • makes watch-admin default behaviour

Why is it needed?

  • the develop command becomes really fast in new projects now
  • CI e2e tests are now 33% quicker

@joshuaellis joshuaellis added source: core:strapi Source is core/strapi package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) flag: documentation This PR requires a documentation update labels Mar 1, 2024
@joshuaellis joshuaellis added this to the 5.0.0 milestone Mar 1, 2024
@joshuaellis joshuaellis self-assigned this Mar 1, 2024
@joshuaellis joshuaellis marked this pull request as ready for review March 1, 2024 10:18
@joshuaellis
Copy link
Member Author

@pwizla this is just a small documentation change for default behaviours :)

innerdvations
innerdvations approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thanks!

@joshuaellis joshuaellis merged commit b4f7a07 into v5/main Mar 1, 2024
104 checks passed
@joshuaellis joshuaellis deleted the chore/make-watch-admin-default branch March 1, 2024 10:39
@derrickmehaffy
Copy link
Member

@joshuaellis does the user have some way to disable this if they want to?

@echoes-hq echoes-hq bot added the echoes/type: documentation Effort spent creating and updating documentation label Mar 1, 2024
@pwizla
Copy link
Contributor

pwizla commented Mar 4, 2024

@pwizla this is just a small documentation change for default behaviours :)

Thank you for the ping, @joshuaellis! I've just documented it with this commit.

@joshuaellis
Copy link
Member Author

@joshuaellis does the user have some way to disable this if they want to?

i thought --watch-admin=false would work, but it doesn't which is a surprise. Anyway, they can disable it with --no-watch-admin 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerdvations innerdvations innerdvations approved these changes

@jhoward1994 jhoward1994 Awaiting requested review from jhoward1994

Assignees

@joshuaellis joshuaellis

Labels
echoes/type: documentation Effort spent creating and updating documentation flag: documentation This PR requires a documentation update pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:strapi Source is core/strapi package
Projects
None yet
Milestone
5.0.0-beta.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joshuaellis @derrickmehaffy @pwizla @innerdvations