Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): fix transfer token tests #19672

Merged
merged 1 commit into from Mar 4, 2024
Merged

test(e2e): fix transfer token tests #19672

merged 1 commit into from Mar 4, 2024

Conversation

joshuaellis
Copy link
Member

What does it do?

  • ensures playwright doesn't use dev-mode (hot reloading fucks with it)
  • fix incorrect routing when successful token has been made

@joshuaellis joshuaellis added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Mar 4, 2024
@joshuaellis joshuaellis self-assigned this Mar 4, 2024
innerdvations
innerdvations approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuaellis joshuaellis merged commit 48b77b6 into v5/main Mar 4, 2024
103 of 104 checks passed
@joshuaellis joshuaellis deleted the chore/fix-transfer-token-tests branch March 4, 2024 16:33
@echoes-hq echoes-hq bot added the echoes/type: maintenance/testing For tests written to support improved automation QA label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerdvations innerdvations innerdvations approved these changes

@jhoward1994 jhoward1994 Awaiting requested review from jhoward1994

Assignees

@joshuaellis joshuaellis

Labels
echoes/type: maintenance/testing For tests written to support improved automation QA pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshuaellis @innerdvations