Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add history document action #19683

Merged
merged 10 commits into from Mar 6, 2024
Merged

feat: add history document action #19683

merged 10 commits into from Mar 6, 2024

Conversation

remidej
Copy link
Contributor

@remidej remidej commented Mar 5, 2024

What does it do?

  • removes the History button that was in an injection zone
  • implement it using a header document action instead
  • show "new" tag only for this document action

Why is it needed?

it's the designs

How to test it?

  • open your own api:: content types in the CM, find the button in the top right overflow menu, click on content history, you should be redirected to the history for that entry
  • open an entry from a content type created by a plugin, the content history menu item should be disabled
  • the menu item should be disabled when you're creating an entry (including when adding a new locale to an already saved document)
  • disable content history via the future flag, you should not see the document action at all

@remidej remidej added source: core:content-manager Source is core/content-manager package pr: feature This PR adds a new feature labels Mar 5, 2024
@remidej remidej self-assigned this Mar 5, 2024
@github-actions GitHub Actions

This comment was marked as spam.

Sign in to view
joshuaellis
joshuaellis reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial round of feedback, need to do some QA but overall looks good 👍🏼

packages/core/types/src/modules/features.ts Outdated Show resolved Hide resolved
packages/core/admin/admin/src/content-manager/history/components/HistoryAction.tsx Outdated Show resolved Hide resolved
packages/core/admin/admin/src/core/apis/content-manager.ts Outdated Show resolved Hide resolved
@remidej remidej requested a review from joshuaellis March 5, 2024 16:52
Base automatically changed from v5/history to v5/main March 5, 2024 17:34
joshuaellis
joshuaellis approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA ✅ looks cool!

Can we make sure we squash this when merging? not sure we need 10 commits for this feat/enhancement 😄

@remidej remidej merged commit 2363945 into v5/main Mar 6, 2024
102 of 103 checks passed
@remidej remidej deleted the history/document-action branch March 6, 2024 09:28
@echoes-hq echoes-hq bot added the echoes/type: feature Effort to deliver new features, significant feature changes and new functionality label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

@simotae14 simotae14 Awaiting requested review from simotae14

@markkaylor markkaylor Awaiting requested review from markkaylor

Assignees

@remidej remidej

Labels
echoes/type: feature Effort to deliver new features, significant feature changes and new functionality pr: feature This PR adds a new feature source: core:content-manager Source is core/content-manager package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@remidej @joshuaellis