chore: deprecate entity-service and delegate to document service #19728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebodin
force-pushed
the
v5/entity-service
branch
16 times, most recently
from
3a67086
to
2463a34
Compare
alexandrebodin
force-pushed
the
v5/entity-service
branch
from
2463a34
to
5ffb3c7
Compare
alexandrebodin
added
pr: chore
Marc-Roig
reviewed
Mar 13, 2024
Marc-Roig
reviewed
Mar 13, 2024
| ...query, | ||
| where: { id: entityId }, | ||
| }); | ||
| const entityToDelete = await db.query(uid).findOne({ where: { id: entityId } }); |
There was a problem hiding this comment.
minor thing, should we support deleting components? Or things that are not content types (media for example, which will be in the future but not now).
There was a problem hiding this comment.
this is handled in the strapi.documents().delete already 🤔
There was a problem hiding this comment.
I meant directly using the component uid to delete it (same as for create and update).
It is just a random thought to provide more v4 compatibilty
There was a problem hiding this comment.
Ok will do another PR to add more compat
Marc-Roig
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
removes as much as possible calls to entityService in internal code where it shouldn't be used
Why is it needed?
To deprecate it correctly.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request