Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admin): create internal history for universal back button #19746

Merged
merged 5 commits into from Mar 15, 2024
Merged

feat(admin): create internal history for universal back button #19746

merged 5 commits into from Mar 15, 2024

Conversation

joshuaellis
Copy link
Member

What does it do?

  • introduces a universal back-button that can / should be implemented on all pages, it records the internal app state so it won't cause the user to leave the application, instead it disables itself. It also works across the entire app without needing to know paths.

Why is it needed?

  • user-story from design

Related issue(s)/PR(s)

  • resolves CONTENT-2173

@joshuaellis joshuaellis added source: core:admin Source is core/admin package pr: enhancement This PR adds or updates some part of the codebase or features labels Mar 12, 2024
@joshuaellis joshuaellis added this to the 5.0.0 milestone Mar 12, 2024
@joshuaellis joshuaellis self-assigned this Mar 12, 2024
@jhoward1994
Copy link
Contributor

This is really cool ❤️. Is there a plan to cover it with tests?

@joshuaellis
Copy link
Member Author

Is there a plan to cover it with tests?

Id like too, i couldn't figure out an easy way to do it because you need to do loads of in-app navigations to test it works effectively, what do you think?

joshuaellis and others added 4 commits March 14, 2024 21:58
@joshuaellis
feat(admin): create internal history for universal back button
e74de05
@joshuaellis @jhoward1994
chore: remove erroneous return
d58e60a 
Co-authored-by: Jamie Howard <48524071+jhoward1994@users.noreply.github.com>
@joshuaellis @jhoward1994
chore: rename SET_ABILITY_TO_NAVIGATE to SET_CAN_GO_BACK
216f545 
Co-authored-by: Jamie Howard <48524071+jhoward1994@users.noreply.github.com>
@joshuaellis
chore: remove middlewares file
766a55b
@vercel Vercel
Copy link

vercel bot commented Mar 14, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ❌ Failed (Inspect) Mar 15, 2024 8:13am

@joshuaellis joshuaellis merged commit 1cbd1d1 into v5/main Mar 15, 2024
101 of 104 checks passed
@joshuaellis joshuaellis deleted the feat/back-button branch March 15, 2024 11:18
@echoes-hq echoes-hq bot added the echoes/type: feature/enhancement For enhancements to existing functionality and tools label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoward1994 jhoward1994 jhoward1994 approved these changes

@madhurisandbhor madhurisandbhor Awaiting requested review from madhurisandbhor

@Feranchz Feranchz Awaiting requested review from Feranchz

Assignees

@joshuaellis joshuaellis

Labels
echoes/type: feature/enhancement For enhancements to existing functionality and tools pr: enhancement This PR adds or updates some part of the codebase or features source: core:admin Source is core/admin package
Projects
None yet
Milestone
5.0.0-beta.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshuaellis @jhoward1994