Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: helper plugin remove difference util #19757

Merged
merged 3 commits into from
Mar 13, 2024
Merged

chore: helper plugin remove difference util #19757

merged 3 commits into from
Mar 13, 2024

Conversation

simotae14
Copy link
Contributor

What does it do?

  • remove the difference util used only inside the Permissions component

Why is it needed?

  • we can just move the code of difference directly in the component

@simotae14 simotae14 added source: core:helper-plugin Source is core/helper-plugin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Mar 13, 2024
@simotae14 simotae14 self-assigned this Mar 13, 2024
@simotae14 simotae14 merged commit d87468f into v5/main Mar 13, 2024
101 of 104 checks passed
@simotae14 simotae14 deleted the chore/helper-plugin-utils-difference branch March 13, 2024 20:03
@echoes-hq echoes-hq bot added echoes/type: maintenance Upkeeping efforts, chores and catch-up corrective improvements that are not features nor bugs echoes/type: maintenance/refactor For work refactoring tech debt or legacy work labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees

@simotae14 simotae14

Labels
echoes/type: maintenance/refactor For work refactoring tech debt or legacy work echoes/type: maintenance Upkeeping efforts, chores and catch-up corrective improvements that are not features nor bugs pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:helper-plugin Source is core/helper-plugin package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simotae14 @joshuaellis