Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not send status relations #19776

Merged

Conversation

Marc-Roig
Copy link
Contributor

@Marc-Roig Marc-Roig commented Mar 14, 2024

What does it do?

Do not send any status on relations if draft and publish is disabled on the target content type.

@Marc-Roig Marc-Roig self-assigned this Mar 14, 2024
Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 9:36am

@joshuaellis
Copy link
Member

Is status optional on the contract?

@jhoward1994
Copy link
Contributor

Not in the response

status: Documents.Params.PublicationStatus.Kind;
locale?: Documents.Params.Locale;

I think we should change that

@joshuaellis
Copy link
Member

I concur. I will add FE on top of this PR, so I'll make the change? 🥸

@Marc-Roig
Copy link
Contributor Author

missed you rcomment! just added the change in the contract

@joshuaellis
Copy link
Member

I've added the FE parts but i can't see relations

CleanShot.2024-03-14.at.13.43.20.mp4

@joshuaellis
Copy link
Member

Does this need something else before we can merge? i.e. to solve the above issue i shared?

@joshuaellis joshuaellis reopened this Mar 18, 2024
@joshuaellis
Copy link
Member

wrong button.

@Marc-Roig
Copy link
Contributor Author

Relations are appearing for those cases but I still see the status tag, and the api is not returning any status for those relations

@Marc-Roig
Copy link
Contributor Author

edit, I can handle it :) it's just a line of code 🫡

@joshuaellis joshuaellis changed the base branch from v5/main to releases/v5-beta March 18, 2024 09:46
@Marc-Roig Marc-Roig merged commit a2741e3 into releases/v5-beta Mar 18, 2024
78 of 84 checks passed
@Marc-Roig Marc-Roig deleted the v5/relations-dont-send-status-on-disabled-dp branch March 18, 2024 10:21
@echoes-hq echoes-hq bot added the echoes/type: maintenance Upkeeping efforts, chores and catch-up corrective improvements that are not features nor bugs label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/type: maintenance Upkeeping efforts, chores and catch-up corrective improvements that are not features nor bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants