Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: move confirm dialog to admin package and refactor #19782

Merged
merged 1 commit into from Mar 15, 2024

Conversation

joshuaellis
Copy link
Member

What does it do?

  • moves and refactors the ConfirmDialog

Why is it needed?

  • lighter & easier to work with 99% of usecases.

@joshuaellis joshuaellis added source: core:helper-plugin Source is core/helper-plugin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Mar 14, 2024
@joshuaellis joshuaellis added this to the 5.0.0 milestone Mar 14, 2024
@joshuaellis joshuaellis self-assigned this Mar 14, 2024
Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 3:06pm

This comment was marked as spam.

Base automatically changed from chore/helper-plugin-table to v5/main March 15, 2024 14:33
@joshuaellis joshuaellis force-pushed the chore/move-confirm-dialog branch 2 times, most recently from 1268249 to 5b32844 Compare March 15, 2024 14:46
@joshuaellis joshuaellis merged commit f2e8926 into v5/main Mar 15, 2024
82 of 85 checks passed
@joshuaellis joshuaellis deleted the chore/move-confirm-dialog branch March 15, 2024 15:33
@echoes-hq echoes-hq bot added the echoes/type: maintenance/refactor For work refactoring tech debt or legacy work label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/type: maintenance/refactor For work refactoring tech debt or legacy work pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:helper-plugin Source is core/helper-plugin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant