enhancement(database)!: shorten prefixes and suffixes used in identifiers #19783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerdvations
added
source: core:database
innerdvations
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…short-db-prefixes
2 tasks
…short-db-prefixes
innerdvations
changed the title
…short-db-prefixes
…short-db-prefixes
Convly
reviewed
Mar 19, 2024
Comment on lines
138
to
140
| * @param {NameToken[]} nameTokens - Array of name tokens | ||
| * @param {number} [maxLength] - Maximum length for the final name string. | ||
| * @param {NameFromTokenOptions} options - Name token options | ||
| * @returns {string} The generated name string within maxLength. |
There was a problem hiding this comment.
I don't think we need to keep those jsdoc tags since we already have the TS types
Bassel17
requested changes
Mar 19, 2024
| index: 'idx', | ||
| inv_fk: 'ifk', | ||
| order_fk: 'ofk', | ||
| id_column_index: 'idix', |
There was a problem hiding this comment.
shouldn't this be shortened to something like this, i mean looking at how we are shortening index everywhere else
Suggested change
| id_column_index: 'idix', | |
| id_column_index: 'ididx', |
There was a problem hiding this comment.
I used idix because that's what was in the RFC but I have no idea where that came from or why. If anyone wants to vote here, I'll go with whatever the consensus is, I don't think it's super important as long as we document it.
…short-db-prefixes
innerdvations
merged commit 1a78eec
into
enhancement/short-db-names-migration
80 of 82 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Use shorter prefixes and suffixes in generated metadata, for example using "cmps" instead of "components" and "lnk" instead of "links"
Why is it needed?
To make more space available for the actual names of content types and attribute in our database names
How to test it?
See #19732 and follow the same testing instructions. The only difference is that now suffixes and prefixes should also be renamed to the shorter versions.
Related issue(s)/PR(s)
The core migration without shorter prefixes and suffixes: #19732