Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove locale when disabling i18n #19819

Merged
merged 3 commits into from Mar 19, 2024
Merged

Conversation

Marc-Roig
Copy link
Contributor

What does it do?

Locales other than the default one were deleted when disabling i18n, but the left default locale was not set to null.

@Marc-Roig Marc-Roig added source: plugin:i18n Source is plugin/i18n package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Mar 18, 2024
@Marc-Roig Marc-Roig added this to the 5.0.0-beta.0 milestone Mar 18, 2024
@Marc-Roig Marc-Roig self-assigned this Mar 18, 2024
Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ❌ Failed (Inspect) Mar 18, 2024 4:05pm

@Marc-Roig Marc-Roig merged commit 858ad95 into releases/v5-beta Mar 19, 2024
79 of 84 checks passed
@Marc-Roig Marc-Roig deleted the v5/locale-null branch March 19, 2024 08:32
@echoes-hq echoes-hq bot added the echoes/type: maintenance Upkeeping efforts, chores and catch-up corrective improvements that are not features nor bugs label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/type: maintenance Upkeeping efforts, chores and catch-up corrective improvements that are not features nor bugs pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: plugin:i18n Source is plugin/i18n package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants