-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: failed to dynamically load chunk #19821
fix: failed to dynamically load chunk #19821
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was here :D
I'm trying to remember why i had this, I think previously i had vite eating every request incl. API calls for the admin panel is this now not the case? |
Apparently API requests are correctly defered to the backend, apparently everything is working but we might want to be sure about it |
If the E2E tests work, then I am happy for this to go! |
released an experimental Will share it if e2e tests pass! |
@alexandrebodin I am a mere spectator, you did all the work :P |
tests are passing and the "Failed to fetch dynamically" errors can not be reproduced anymore 🚀 will merge the pr |
What does it do?
We were manually checking if the requested url was from a bit chunk file. This is actually handled automatically by vite middlewares, and apparently doesn't have the "Failed to dynamically load..." error