Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to dynamically load chunk #19821

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Marc-Roig
Copy link
Contributor

What does it do?

We were manually checking if the requested url was from a bit chunk file. This is actually handled automatically by vite middlewares, and apparently doesn't have the "Failed to dynamically load..." error

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 1:32pm

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was here :D

@alexandrebodin alexandrebodin added pr: fix This PR is fixing a bug source: core:core Source is core/core labels Mar 18, 2024
@joshuaellis
Copy link
Member

I'm trying to remember why i had this, I think previously i had vite eating every request incl. API calls for the admin panel is this now not the case?

@Marc-Roig
Copy link
Contributor Author

Apparently API requests are correctly defered to the backend, apparently everything is working but we might want to be sure about it

@joshuaellis
Copy link
Member

Apparently API requests are correctly defered to the backend, apparently everything is working but we might want to be sure about it

If the E2E tests work, then I am happy for this to go!

@Marc-Roig
Copy link
Contributor Author

released an experimental
0.0.0-experimental.94632b9dc1ff6c9600db6db51cd6dd2d693f5204

Will share it if e2e tests pass!

@Marc-Roig
Copy link
Contributor Author

I was here :D

@alexandrebodin I am a mere spectator, you did all the work :P

@strapi strapi deleted a comment from notion-workspace bot Mar 18, 2024
@strapi strapi deleted a comment from notion-workspace bot Mar 18, 2024
@strapi strapi deleted a comment from notion-workspace bot Mar 18, 2024
@joshuaellis joshuaellis added this to the 5.0.0-beta.0 milestone Mar 18, 2024
@Marc-Roig
Copy link
Contributor Author

tests are passing and the "Failed to fetch dynamically" errors can not be reproduced anymore 🚀 will merge the pr

@Marc-Roig Marc-Roig merged commit 1e7fe8e into releases/v5-beta Mar 18, 2024
84 of 87 checks passed
@Marc-Roig Marc-Roig deleted the fix/failed-to-dynamically-load-vite branch March 18, 2024 14:18
@echoes-hq echoes-hq bot added the echoes/type: bug Effort to correct undesirable or incorrect behavior label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/type: bug Effort to correct undesirable or incorrect behavior pr: fix This PR is fixing a bug source: core:core Source is core/core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants