Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(helper-plugin)!: move Notifications & AppInfo to admin #19831

Merged
merged 2 commits into from Mar 18, 2024
Merged

chore(helper-plugin)!: move Notifications & AppInfo to admin #19831

merged 2 commits into from Mar 18, 2024

Conversation

joshuaellis
Copy link
Member

@joshuaellis joshuaellis commented Mar 18, 2024 •
edited

What does it do?

  • moves notifications feature to admin
  • exports useNotification
  • temporarily exports NotificationProvider (until we export render from test-utils)

Related Issues

  • resolves CONTENT-1810

@joshuaellis joshuaellis added flag: 💥 Breaking change This PR contains breaking changes and should not be merged source: core:helper-plugin Source is core/helper-plugin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Mar 18, 2024
@joshuaellis joshuaellis added this to the 5.0.0-beta.0 milestone Mar 18, 2024
@joshuaellis joshuaellis self-assigned this Mar 18, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 18, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 9:00pm

@github-actions GitHub Actions

This comment was marked as spam.

Sign in to view
@joshuaellis joshuaellis force-pushed the v5-beta/move-use-notification branch from 8290fc5 to 26f980f Compare March 18, 2024 20:27
@joshuaellis joshuaellis changed the title chore(helper-plugin)!: move Notifications to admin chore(helper-plugin)!: move Notifications & AppInfo to admin Mar 18, 2024
@joshuaellis joshuaellis force-pushed the v5-beta/move-use-notification branch from 27a5759 to ebe4e33 Compare March 18, 2024 20:46
@joshuaellis joshuaellis merged commit 9567486 into releases/v5-beta Mar 18, 2024
79 of 83 checks passed
@joshuaellis joshuaellis deleted the v5-beta/move-use-notification branch March 18, 2024 21:11
@echoes-hq echoes-hq bot added the echoes/type: feature/deprecation For the deprecation and removal of legacy features label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marc-Roig Marc-Roig Marc-Roig approved these changes

@jhoward1994 jhoward1994 Awaiting requested review from jhoward1994

Assignees

@joshuaellis joshuaellis

Labels
echoes/type: feature/deprecation For the deprecation and removal of legacy features flag: 💥 Breaking change This PR contains breaking changes and should not be merged pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:helper-plugin Source is core/helper-plugin package
Projects
Breaking Change Issues
Status: Done
Milestone
5.0.0-beta.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshuaellis @Marc-Roig