Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(helper-plugin)!: remove stopPropagation #19846

Merged
merged 3 commits into from Mar 19, 2024
Merged

chore(helper-plugin)!: remove stopPropagation #19846

merged 3 commits into from Mar 19, 2024

Conversation

simotae14
Copy link
Contributor

@simotae14 simotae14 commented Mar 19, 2024 •
edited

What does it do?

  • removes stopPropagation util and use instead the onClick event stopPropagation
  • remove onRowClick function ad use instead the onClick event

@simotae14 simotae14 added flag: 💥 Breaking change This PR contains breaking changes and should not be merged source: core:helper-plugin Source is core/helper-plugin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Mar 19, 2024
@simotae14 simotae14 self-assigned this Mar 19, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 5:39pm

@joshuaellis joshuaellis added this to the 5.0.0-beta.0 milestone Mar 19, 2024
@joshuaellis joshuaellis merged commit bef2911 into releases/v5-beta Mar 19, 2024
80 of 84 checks passed
@joshuaellis joshuaellis deleted the chore/helper-plugin-remove-stop-propagation branch March 19, 2024 17:47
@echoes-hq echoes-hq bot added echoes/type: maintenance Upkeeping efforts, chores and catch-up corrective improvements that are not features nor bugs echoes/type: maintenance/refactor For work refactoring tech debt or legacy work labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees

@simotae14 simotae14

Labels
echoes/type: maintenance/refactor For work refactoring tech debt or legacy work echoes/type: maintenance Upkeeping efforts, chores and catch-up corrective improvements that are not features nor bugs flag: 💥 Breaking change This PR contains breaking changes and should not be merged pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:helper-plugin Source is core/helper-plugin package
Projects
Breaking Change Issues
Status: Done
Milestone
5.0.0-beta.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simotae14 @joshuaellis