Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link add target _blank #19848

Closed
wants to merge 1 commit into from

Conversation

selmansem
Copy link

What does it do?

Specify target blank attribute to make the link open in a new tab.

Why is it needed?

The plugin information link was opening on the same tab as the administration panel. That makes the user have to open the admin panel in a new tab again.

How to test it?

Before:

Grabaciondepantalla2024-03-19alas21 01 52-ezgif com-video-to-gif-converter

After:

Grabaciondepantalla2024-03-19alas21 31 38-ezgif com-video-to-gif-converter

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ❌ Failed (Inspect) Mar 19, 2024 9:51pm

@haZya
Copy link

haZya commented May 20, 2024

This should not be fixed within this repo as the roots of this issue go all the way down to the strapi-design-system.

There is a PR for this there and it doesn't have a clean fix as it seems to be a limitation of how the design system is currently configured with styled-components.

@selmansem
Copy link
Author

Thanks @haZya . I didn't get to that point.

So this solution is only valid if I am building the project 'for me'? It would not be a fix to apply in the repo?

@haZya
Copy link

haZya commented May 20, 2024

@selmansem Yup. Pretty much.

@selmansem selmansem closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
Status: Fixed/Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants