fix: add support for private upload providers

[Bassel17]

What does it do?

• Signs urls when they are coming from a private upload provider

Why is it needed?

• users can't export and transfer files from private upload providers

How to test it?

• create a private upload provider and attempt to export, import and transfer
• make sure that normal transfer work the same and are not affected by the changes

you can follow the example provided in this issue #17571

Related issue(s)/PR(s)

fix #17571

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
contributor-docs	❌ Failed (Inspect)			Mar 21, 2024 10:43am

[Convly]

I'm a bit surprised that the upload plugin doesn't handle the signature itself 🙁

[innerdvations]

I'm a bit surprised that the upload plugin doesn't handle the signature itself 🙁

Yeah, if this fix works for DTS I think we can move ahead with it, but we should add to the backlog to fix it globally if possible

[Bassel17]

I'm a bit surprised that the upload plugin doesn't handle the signature itself 🙁

it does, just at a different level, we only use the upload from the plugin itself,
fetching and getting the file itself we get based on the file entity data, in which we have a url that is not signed

[innerdvations]

Code LGTM but won't have time to QA until tomorrow

[christiancp100]

Code LGTM! Good job!

[Convly]

LGTM code-wise

[derrickmehaffy]

FYI for functional QA testing there is a private S3 bucket we use in our internal AWS for specifically testing this stuff, take a look in the company shared password manager.