Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve foreign key error on push transfers #19870

Merged
merged 3 commits into from Mar 22, 2024
Merged

Conversation

christiancp100
Copy link
Member

What does it do?

It solves the foreign key error on push transfers by fixing the way we are getting the component UIDs when mapping the old IDs and the new IDs.

Why is it needed?

To avoid FK Constraint errors on transfers.

How to test it?

Create a content type with a component and a repeatable component, both containing relation to another content type inside. Fill them with data and execute an export/import and/or a transfer. It should work without displaying any warning about a foreign key constraint.

Related issue(s)/PR(s)

#18350

@christiancp100 christiancp100 added pr: fix This PR is fixing a bug source: core:data-transfer Source is core/data-transfer package labels Mar 21, 2024
@christiancp100 christiancp100 self-assigned this Mar 21, 2024
Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ❌ Failed (Inspect) Mar 22, 2024 10:23am

Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, LGTM, haven't QAd yet though

@innerdvations innerdvations self-requested a review March 22, 2024 10:18
Copy link
Member

@Bassel17 Bassel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks greattt

Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, QA worked!

@christiancp100 christiancp100 merged commit 10659c5 into develop Mar 22, 2024
30 of 31 checks passed
@christiancp100 christiancp100 deleted the fix/dts-fk-constraint branch March 22, 2024 11:02
@hanpaine hanpaine added this to the 4.21.1 milestone Mar 26, 2024
@echoes-hq echoes-hq bot added the echoes/type: bug Effort to correct undesirable or incorrect behavior label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/type: bug Effort to correct undesirable or incorrect behavior pr: fix This PR is fixing a bug source: core:data-transfer Source is core/data-transfer package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants