chore: upgrade prettier to 3.2.5 (poc for dynamic imports of pure esm) #19876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 2.39 MB ℹ️ View Unchanged
|
innerdvations
changed the title
innerdvations
added
flag: don't merge
Co-authored-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com>
alexandrebodin
approved these changes
Mar 26, 2024
Convly
approved these changes
Mar 28, 2024
| @@ -61,6 +60,9 @@ const saveDefinitionToFileSystem = async (dir, file, content) => { | |||
| * @returns {Promise<string>} | |||
| */ | |||
| const format = async (content) => { | |||
| // eslint-disable-next-line node/no-unsupported-features/es-syntax | |||
| const prettier = await import('prettier'); // ESM-only | |||
There was a problem hiding this comment.
Did you test that the auto type gen still works well?
|
I've found a tooling related issue with this, so I'm holding off on merging until I get some opinions. If you check out this PR in VS Code, it updates to use prettier v3. If you then switch back to |
it happens to me with a lot of extensions incl eslint & prettier. consider everyone has practicaly switch on v5 I would not bother |
echoes-hq
bot
added
the
echoes/type: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
await import('prettier')for each place that was changed)prettier:writeand updated 100+ files because apparently prettier v3 treats all warnings as errors, or at least changes the process exit code so CI was failingWhy is it needed?
Upgrading prettier isn't really needed. However, the node ecosystem as a whole is shifting towards esm-only and almost every module we use that has major version upgrades all require esm.
We need a strategy to work around it, at least until Node fixes the problem which is on the horizon.
Prettier seems a safe enough place to experiment with using it, it would be easy to downgrade later if we need to without any breaking changes.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
DX-1273