chore: introduce query-params service to remove strapi.global dep in … #19911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebodin
added
source: core:utils
|
do we plan to have a transform query to params? If so, could it be useful to name this method |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexandrebodin
force-pushed
the
v5/utils-refactors
branch
from
b48fd4c
to
6449ad5
Compare
There should only be one direction params -> query 🤔 |
alexandrebodin
force-pushed
the
v5/utils-refactors
branch
from
6449ad5
to
3f6a810
Compare
Marc-Roig
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…utils
What does it do?
Introduce
query-paramsservice to expose query param transformation in the context of the strapi app & remove the need for the strapi global inside the utils.Next step move the conversion code where it makes more sense (TBD in another PR)