(content-manager): ask for confirmation of d&p tab change #19912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoward1994
changed the title
jhoward1994
added
source: core:content-manager
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Code looks fine on face value, there's an issue where if i click CleanShot.2024-03-27.at.10.21.06.mp4What is neat, is it works for i18n too, which i think is something we probably forgot about anyway. |
|
Hmmm weird I cant reproduce that. Are you just running 'yarn develop' from getstarted? |
yes, i ran |
|
Anything in the console that suggests why that happened? |
|
Okay so having a deeper look, when you first go on an entry we dont set a query param to You might actually want to pass a predicate function to |
|
Check the logs carefully particularly the query, you should see what im saying 😄 CleanShot.2024-03-27.at.12.09.33.mp4 |
jhoward1994
force-pushed
the
fix/confirm-modified-tab-change
branch
from
593176c
to
9329a2a
Compare
jhoward1994
added
the
flag: don't merge
|
Depends on changes to the design system tab components |
|
@joshuaellis this is working for me with our DS changes. The only thing is the blocker still needs to listen for changes to the query and have an I'll open a PR with the DS changes |
joshuaellis
reviewed
Mar 28, 2024
| @@ -690,15 +690,19 @@ const isErrorMessageDescriptor = (object?: string | object): object is Translati | |||
| /* ------------------------------------------------------------------------------------------------- | |||
| * Blocker | |||
| * -----------------------------------------------------------------------------------------------*/ | |||
| const Blocker = () => { | |||
| const Blocker = ({ onProceed = () => {} }) => { | |||
There was a problem hiding this comment.
for consistency, can we add an onCancel and write an interface for the types with docs so they appear in the auto-generator and they're helpful?
|
Size Change: +1.12 kB (0%) Total Size: 2.38 MB
ℹ️ View Unchanged
|
joshuaellis
approved these changes
Apr 4, 2024
joshuaellis
removed
the
flag: don't merge
echoes-hq
bot
added
the
echoes/type: feature/new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
location.searchWhy is it needed?
So form data isn't lost without confirmation
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
CONTENT-2298