Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow graphql get request with authentication #19916

Merged
merged 1 commit into from Mar 26, 2024
Merged

chore: allow graphql get request with authentication #19916

merged 1 commit into from Mar 26, 2024

Conversation

alexandrebodin
Copy link
Member

What does it do?

Allows get request. I couldn't find any reason to keep the old code arround.

@alexandrebodin alexandrebodin added source: plugin:graphql Source is plugin/graphql package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Mar 25, 2024
@alexandrebodin alexandrebodin self-assigned this Mar 25, 2024
@innerdvations
Copy link
Contributor

Fixes/implements #18979 and #14601

innerdvations
innerdvations approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@innerdvations innerdvations left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested that auth still works with GET. Any idea why this was added originally? I remember adding those comments a while back but was afraid to remove the actual code in v4

@alexandrebodin
Copy link
Member Author

LGTM, tested that auth still works with GET. Any idea why this was added originally? I remember adding those comments a while back but was afraid to remove the actual code in v4

I think someone missunderstood strapi.auth.anthenticate & strapi.auth.verify

@alexandrebodin alexandrebodin merged commit 2c602ff into v5/main Mar 26, 2024
82 of 86 checks passed
@alexandrebodin alexandrebodin deleted the v5/graphql-get branch March 26, 2024 09:57
@innerdvations
Copy link
Contributor

We may want to accept #19168 as well for v4

@derrickmehaffy derrickmehaffy mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerdvations innerdvations innerdvations approved these changes

Assignees

@alexandrebodin alexandrebodin

Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: plugin:graphql Source is plugin/graphql package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandrebodin @innerdvations