chore(admin): remove react-helmet #19923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 3.08 MB ℹ️ View Unchanged
|
joshuaellis
added
source: core:admin
joshuaellis
reviewed
Mar 26, 2024
| children: string; | ||
| } | ||
|
|
||
| const Title = ({ children: title }: TitleProps) => { |
There was a problem hiding this comment.
This could do with some JSDoc since it's public 👍🏼
There was a problem hiding this comment.
^^ just for future reference.
joshuaellis
force-pushed
the
chore/remove-react-helmet
branch
from
c3f2ca0
to
13345b7
Compare
joshuaellis
force-pushed
the
chore/remove-react-helmet
branch
from
6419bc8
to
594210b
Compare
jhoward1994
reviewed
Mar 26, 2024
jhoward1994
approved these changes
Mar 26, 2024
joshuaellis
force-pushed
the
chore/remove-react-helmet
branch
from
594210b
to
99415c5
Compare
echoes-hq
bot
added
the
echoes/type: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It removes the react-helmet dependency from all the packages
Why is it needed?
React Helmet adds unnecessary weight to Strapi
How to test it?
Test that the titles work as they were working before
Related issue(s)/PR(s)