New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: internal core refactorings #19943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebodin
added
pr: chore
This PR contains chore tasks (cleanups, configs, tooling...)
source: core:core
Source is core/core
labels
Mar 27, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexandrebodin
changed the title
chore: remove loadedStrapi and init everything but admin in constructor
chore: internal core refactorings
Mar 27, 2024
Marc-Roig
reviewed
Mar 28, 2024
Marc-Roig
reviewed
Mar 28, 2024
Marc-Roig
reviewed
Apr 2, 2024
Marc-Roig
approved these changes
Apr 2, 2024
Convly
approved these changes
Apr 2, 2024
alexandrebodin
force-pushed
the
v5/core
branch
2 times, most recently
from
April 2, 2024 14:37
a1599a3
to
2560097
Compare
alexandrebodin
force-pushed
the
v5/core
branch
2 times, most recently
from
April 2, 2024 15:16
ad8047e
to
c3178ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: chore
This PR contains chore tasks (cleanups, configs, tooling...)
source: core:core
Source is core/core
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Remove loadedStrapi and init everything but admin in constructor