fix(releases): On edit release error dont close modal #19946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhurisandbhor
changed the title
madhurisandbhor
added
pr: fix
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
simotae14
approved these changes
Mar 28, 2024
|
Tested, and it works, well done @madhurisandbhor 👏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
On edit release error, don't close modal and user should be able to edit details.
Previously it used to close irrespective of the status
How to test it?
On editing release, if error appears it should not close the modal.