test(e2e): close notification boxes after confirming they exist #19947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…trapi/strapi into test/e2e-close-saved-popups-v5
innerdvations
changed the title
innerdvations
changed the title
mazzucchelli
approved these changes
Mar 29, 2024
echoes-hq
bot
added
the
echoes/type: maintenance/testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Patches in the same util as v4
and then uses it in all the new tests that were added in v5
As a side effect, the tests run a lot faster because we're not waiting for the popup to close on its own
Why is it needed?
The tests run fast, and multiple notification boxes appear at once unless we explicitly wait for them to disappear each time, resulting in slower test runs if we aren't intentionally wanting to test that they disappear on their own.
This uses the util for finding and closing them everywhere
How to test it?
e2e tests should pass
Related issue(s)/PR(s)
Clone of v4 fix #19941