feat(admin): rbac middleware #19949
Merged
feat(admin): rbac middleware #19949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaellis
added
flag: 💥 Breaking change
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
simotae14
reviewed
Mar 28, 2024
simotae14
reviewed
Mar 28, 2024
simotae14
reviewed
Mar 28, 2024
| @@ -273,7 +274,8 @@ const ProtectedEditViewPage = () => { | |||
| slug: string; | |||
| }>(); | |||
| const [{ query }] = useQueryParams(); | |||
| const { permissions = [], isLoading, isError } = useSyncRbac(slug ?? '', query, 'editView'); | |||
| const {} = useRBAC; | |||
There was a problem hiding this comment.
sorry I don't understand why you are calling twice useRBAC
There was a problem hiding this comment.
this isn't finished 😄 it was just testing some bits!!
joshuaellis
force-pushed
the
feat/v5-rbac-middleware
branch
from
a28f946
to
cc2ae46
Compare
joshuaellis
force-pushed
the
feat/v5-rbac-middleware
branch
from
cc2ae46
to
4ff5551
Compare
joshuaellis
changed the title
|
Size Change: 0 B Total Size: 2.38 MB ℹ️ View Unchanged
|
joshuaellis
force-pushed
the
feat/v5-rbac-middleware
branch
from
4ff5551
to
0caa89f
Compare
joshuaellis
force-pushed
the
feat/v5-rbac-middleware
branch
from
0caa89f
to
9c3b21b
Compare
innerdvations
approved these changes
Apr 8, 2024
Comment on lines
+29
to
+30
| use(middleware: RBACMiddleware[]): void; | ||
| use(middleware: RBACMiddleware): void; |
There was a problem hiding this comment.
Suggested change
| use(middleware: RBACMiddleware[]): void; | |
| use(middleware: RBACMiddleware): void; |
Do we need those? We've got the same types below
|
StrapiApp is autodocumented 😎
But i'll also add it to the docs for piwi if he feels it right |
echoes-hq
bot
added
the
echoes/type: feature/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
useAuth.checkUserHasPermissionsto return an array of permissions not a booleanuseRBACnow returns an array of permissionsuseRBACnow preferably wants an array and ignores keys of the object, so the action names are derived from theactionproperty of thepermission.Why is it needed?
Related issue(s)/PR(s)