Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(history): simplify the meta object #19990

Merged
merged 3 commits into from Apr 2, 2024

Conversation

markkaylor
Copy link
Contributor

What does it do?

  • Make the meta.unknownAttributes constant in the response
  • Use the strapi type for schema attributes

Why is it needed?

  • To simplify and have a more predictable response object

How to test it?

  • Everything should work the same. You should always be able to access versions.meta.unknownAttributes.added | .removed

@markkaylor markkaylor added source: core:content-manager Source is core/content-manager package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Apr 2, 2024
@markkaylor markkaylor requested a review from remidej April 2, 2024 15:01
@markkaylor markkaylor self-assigned this Apr 2, 2024
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 3:55pm

Copy link
Contributor

@remidej remidej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the simplification

@markkaylor
Copy link
Contributor Author

I don't believe any of the failing tests are related to the changes here...

@markkaylor markkaylor merged commit 9711681 into v5/main Apr 2, 2024
20 of 30 checks passed
@markkaylor markkaylor deleted the chore/history-version-meta branch April 2, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants