fix: making api tokens creation work #20009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassel17
added
source: core:admin
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/core/admin/admin/src/pages/Settings/pages/ApiTokens/EditView/EditViewPage.tsx
Show resolved
Hide resolved
joshuaellis
reviewed
Apr 3, 2024
packages/core/admin/admin/src/pages/Settings/pages/ApiTokens/EditView/EditViewPage.tsx
Show resolved
Hide resolved
innerdvations
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
LGTM, also QAd it.
After creating an unlimited token, both this and transfer tokens display an empty select item instead of showing "Unlimited"
Is that something you can quickly solve here, or do you want to open another issue for it?
(Update: I created a ticket for it if you want to go ahead and merge this, we can fix that part later)
echoes-hq
bot
added
the
echoes/type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Why is it needed?
How to test it?
Related issue(s)/PR(s)
fix #19994