Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] fix: use admin.url config for root path redirect #20014

Merged
merged 2 commits into from Apr 4, 2024

Conversation

MattieBelt
Copy link
Collaborator

@MattieBelt MattieBelt commented Apr 3, 2024

What does it do?

Use admin.url config option as redirect instead of hardcoded /admin

Why is it needed?

fixes #20013

How to test it?

  1. Add an '/dashboard' or 'https://example.com/' to the url option in config/admin.js
  2. Navigate to http://localhost:1337
  3. Correctly be redirect to configured url

Related issue(s)/PR(s)

fixes: #20013

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 9:00pm

@joshuaellis joshuaellis added pr: fix This PR is fixing a bug source: core:core Source is core/core labels Apr 3, 2024
@MattieBelt MattieBelt changed the title fix: use admin.url config for root path redirect [v5] fix: use admin.url config for root path redirect Apr 3, 2024
@alexandrebodin
Copy link
Member

@MattieBelt commitlint is unhappy because of a whitespace in your commit 😬

@MattieBelt
Copy link
Collaborator Author

MattieBelt commented Apr 3, 2024

@MattieBelt commitlint is unhappy because of a whitespace in your commit 😬

Fixed 😄
I tried to do it quickly via GH web, but that trailing whitespace haha

Commitlint is happy now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:core Source is core/core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants