Refactor cli version test #20024
Merged
Refactor cli version test #20024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of deleting it, can it be changed to just expect any valid semver? It's nice to have a test for every command so we don't accidentally break it or lose it. |
Yes, we can, but this was an example test, do we want to keep it? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 2.38 MB ℹ️ View Unchanged
|
alexandrebodin
approved these changes
Apr 4, 2024
alexandrebodin
added
source: cli
If it works, yeah, it's still a valid test. But this update seems great, thanks! |
innerdvations
approved these changes
Apr 4, 2024
echoes-hq
bot
added
the
echoes/type: maintenance/testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It verifies that the output from the strapi version command is a valid semver.
Why is it needed?
This way the test is easy to maintain while still verifies the version command.
How to test it?
Check all the cli tests pass
Related issue(s)/PR(s)